-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appGUID attribute to droplet resource [v8] #2933
Merged
joaopapereira
merged 2 commits into
cloudfoundry:v8
from
gmllt:add-droplets-relationships
Feb 10, 2025
Merged
Add appGUID attribute to droplet resource [v8] #2933
joaopapereira
merged 2 commits into
cloudfoundry:v8
from
gmllt:add-droplets-relationships
Feb 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
PR on main branch : 2932 |
e43b64d
to
c9fb1af
Compare
c9fb1af
to
5ed73cd
Compare
5ed73cd
to
56cc3cc
Compare
56cc3cc
to
3cacfa7
Compare
3cacfa7
to
e4e38c9
Compare
@dependabot rebase |
e4e38c9
to
e122508
Compare
1be6b54
to
37302c4
Compare
37302c4
to
316d54d
Compare
316d54d
to
ccdd886
Compare
ccdd886
to
2ae50f4
Compare
joaopapereira
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where this PR should be backported?
Description of the Change
The V3 API allows you to access to the relationships existing beween a droplet and its related app.
This PR make this relationship visible trough a new
AppGUID
attribute in the resourcedroplet
.The community
cf_exporter
currently use the/v2/spaces/:guid/summary
endpoint to gain access to buildpack associated to an application. Have this relationship visible would help get rid of calls on this endpoint and retrieve buildpacks attached to an application through its droplets.This feature is necessary for applications using the cli product in go development to established relationship between an
application
resource and its droplets.This feature will not cause breaking change.