-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial BOSH Release #1222
Initial BOSH Release #1222
Conversation
@irfanhabib Do we have to have "stratos-ui-release" folder? can we call it bosh? Can it move down a level? We tried to reduce the number of top-level folders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stratos-ui-release/README.md
Outdated
**Note:** BOSH release is currently experimental. It currently has only been tested in a BOSH Lite environment, any suggestions for improvements to support other BOSH environments are welcome. | ||
|
||
To build and deploy the BOSH release you will require a BOSH director. If you don't have one available follow these instructions to setup BOSH lite [here](https://bosh.io/docs/bosh-lite.html). | ||
The rest of the instruction assume that a BOSH lite environment is being used to deploy the chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"'chart" should be "console"
stratos-ui-release/README.md
Outdated
|
||
3. Build the Stratos UI BOSH release | ||
``` | ||
$ bosh create-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to be in the stratots-ui-release folder - need to add this to the instructions.
stratos-ui-release/README.md
Outdated
``` | ||
|
||
5. Deploy the release | ||
A sample bosh-lite deployment manifest has been provided in `bosh-lite/deployment.yaml`. The following will use that command to deploy the Console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your formatting foes weird in this section.
sub-sections (a) and (b) aren't indented.
I think you are missing ``` under the 5. heading
"To use SQLlite" - this is not formatted correctly which has knock-ons for the text afterwards
NOTE: This depends on #1230