Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address minor bugs in the deploy application for github #1285

Merged
merged 1 commit into from
Oct 6, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@
function DeploySourceGitController($http, $scope) {
var vm = this;

vm.data = {
githubBranches: []
};
// Preserve data in case user goes back and forward in the wizard
vm.userInput.gitData = vm.userInput.gitData || [];
vm.data = vm.userInput.gitData;
vm.data.githubBranches = vm.data.githubBranches || [];

vm.userInput.gitType = vm.userInput.gitType || 'github';
vm.userInput.gitUrlBranch = vm.userInput.gitUrlBranch || 'master';
Expand All @@ -66,7 +67,7 @@
vm.data.githubProject = response.data;
vm.userInput.githubProjectCached = project;

$http.get('https://api.github.com/repos/' + project + '/branches')
$http.get('https://api.github.com/repos/' + project + '/branches?per_page=100')
.then(function (response) {
vm.data.githubBranches.length = 0;
[].push.apply(vm.data.githubBranches, _.map(response.data, function selectOptionMapping(o) {
Expand Down