Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delete job when running in noShared mode #1364

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Conversation

irfanhabib
Copy link
Contributor

Delete Job is required to remove resources created by Jobs, since these are not tracked as part of a Helm release.
Since no Jobs run in noShared mode, this task is not required.

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit db97272 into master Nov 9, 2017
@nwmac nwmac deleted the remove-delete-job branch November 9, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants