Display commit SHA/ Release tag in the About page #2416
Conversation
|
Hey irfanhabib! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2416 +/- ##
=============================================
+ Coverage 71.04% 71.06% +0.01%
=============================================
Files 583 585 +2
Lines 24452 24539 +87
Branches 5483 5508 +25
=============================================
+ Hits 17373 17438 +65
- Misses 7079 7101 +22 |
deploy/stand-up-dev-env.sh
Outdated
| @@ -18,7 +18,7 @@ DEPLOY_PATH=${STRATOS_UI_PATH}/deploy | |||
|
|
|||
| NO_UI=false | |||
| CLEAN=false | |||
|
|
|||
| STRATOS_VERSION=v2.0.0-$(git log -1 --format="%h") | |||
There was a problem hiding this comment.
Can we remove the v so its 2.0.0 ... We should read the 2.0.0 part from the package file, otherwise we'll need to update this everytime we release 2.0.1 etc.
deploy/tools/restart_proxy.sh
Outdated
| @@ -18,12 +18,13 @@ function env_vars { | |||
| pushd "${DEPLOYDIR}" | |||
| ls | |||
| env_vars | |||
|
|
|||
| STRATOS_VERSION=v2.0.0-$(git log -1 --format="%h") | |||
There was a problem hiding this comment.
We should read the 2.0.0 part from the package file, otherwise we'll need to update this everytime we release 2.0.1 etc.
deploy/stand-up-dev-env.sh
Outdated
| @@ -18,7 +18,8 @@ DEPLOY_PATH=${STRATOS_UI_PATH}/deploy | |||
|
|
|||
| NO_UI=false | |||
| CLEAN=false | |||
|
|
|||
| PACKAGE_JSON_VERSION=$(cat ${STRATOS_UI_PATH}/package.json | grep version | grep -Po "([0-9\.]?)*") | |||
There was a problem hiding this comment.
This does not work on Mac - grep -P not supported I think. Not sure about Windows either
There was a problem hiding this comment.
This will work on the mac for the grep command:
grep -Eo "([0-9]*.[0-9]*.[0-9]*)"
|
@nwmac Updated! |
fixes #2410