Postflight script times out if it can not connect #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2547 +/- ##
=============================================
- Coverage 70.42% 70.39% -0.03%
=============================================
Files 594 594
Lines 25132 25132
Branches 5674 5674
=============================================
- Hits 17698 17692 -6
- Misses 7434 7440 +6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2546.
There is a race-condition with the Helm deployment - if the postflight job runs just before the DB Server is ready, it will sit for a long time trying to connect to it to determine if the db schema exists. You'll get the upgrade notice in the UI and it will take longer for Stratos to be available.
This PR fixes this and does a check with a lower timeout (5 seconds). If it can not connect in that time, it bails. Kubernetes will reschedule the post-flight job.. and it will then succeed (maybe after more retries).. but it will do so quickly.