Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker All-in-one image build #2552

Merged
merged 4 commits into from
Jun 28, 2018
Merged

Fix Docker All-in-one image build #2552

merged 4 commits into from
Jun 28, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 27, 2018

This PR:

  • Removes the old docker file from the all-in-one folder
  • Updated the docs
  • Updates the docker file to work with the permissions changes in the new back-end builder image
  • Use build-cf target to build front-end, so that this will work on low-memory systems - it failed on my Mac, but worked on beefier Linux box - tuning down allowed it to build

@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nwmac nwmac self-assigned this Jun 27, 2018
@nwmac nwmac added the V2 label Jun 27, 2018
@nwmac nwmac requested a review from irfanhabib June 27, 2018 17:47
@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #2552 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v2-master    #2552   +/-   ##
==========================================
  Coverage      70.42%   70.42%           
==========================================
  Files            594      594           
  Lines          25132    25132           
  Branches        5674     5674           
==========================================
  Hits           17698    17698           
  Misses          7434     7434

Copy link
Contributor

@irfanhabib irfanhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully builds now in Concourse and locally

@irfanhabib irfanhabib merged commit 4d1922c into v2-master Jun 28, 2018
@irfanhabib irfanhabib deleted the fix-aio branch June 28, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants