Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app instance sorting #2699

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Fix app instance sorting #2699

merged 2 commits into from
Jul 19, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jul 19, 2018

Fixes: #2698

@nwmac nwmac self-assigned this Jul 19, 2018
@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nwmac nwmac added bug V2 P1 Priority 1 labels Jul 19, 2018
@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #2699 into v2-master will increase coverage by <.01%.
The diff coverage is 52.63%.

@@              Coverage Diff              @@
##           v2-master    #2699      +/-   ##
=============================================
+ Coverage      70.06%   70.06%   +<.01%     
=============================================
  Files            599      599              
  Lines          25482    25496      +14     
  Branches        5757     5762       +5     
=============================================
+ Hits           17853    17864      +11     
- Misses          7629     7632       +3

@irfanhabib
Copy link
Contributor

LGTM

@irfanhabib irfanhabib merged commit 204c32e into v2-master Jul 19, 2018
@irfanhabib irfanhabib deleted the fix-instance-index-sorting branch July 19, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review P1 Priority 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants