Fix several manage user role bugs #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix false warning for too many roles - Fix comparison (handle situation where there's no missing users) - Fix process of creating a pagination section from a parent. - Fetch org spaces.. - Org entity has spaces param - Populate space pagination section unsing org entity's spaces
- Org user cross should be disabled if there are other roles within the same organisation OR the organisation has space roles - Fix 1 - Enable cross of org user pill if the only org role is itself - Fix 2 - When checking if an organisation has space roles ignore spaces from other organisations
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2826 +/- ##
=============================================
+ Coverage 71.35% 71.35% +<.01%
=============================================
Files 605 605
Lines 25895 25897 +2
Branches 5872 5874 +2
=============================================
+ Hits 18478 18480 +2
Misses 7417 7417 |
nwmac
reviewed
Aug 31, 2018
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
Shouldn't this have the return false? or change the if to a return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the edit of users by an admin at cf/org levels …
Fix disable of org role pill cross …