Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint list: Show logged in user's username and whether they're an admin or not. #2827

Merged
merged 5 commits into from
Aug 31, 2018

Conversation

KlapTrap
Copy link
Contributor

fixes #2324

@cfdreddbot
Copy link

Hey KlapTrap!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #2827 into v2-master will increase coverage by 0.01%.
The diff coverage is 84.21%.

@@              Coverage Diff              @@
##           v2-master    #2827      +/-   ##
=============================================
+ Coverage      71.29%   71.31%   +0.01%     
=============================================
  Files            604      605       +1     
  Lines          25834    25872      +38     
  Branches        5853     5865      +12     
=============================================
+ Hits           18419    18451      +32     
- Misses          7415     7421       +6

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes, worth a quick re-review

  • Used the same admin/not admin indicator as in the multi cf card. Also applied this to the cf summary card. For metrics endpoints just show a -
  • Fixed sort when there's metrics endpoints without a user param

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 942ca74 into v2-master Aug 31, 2018
@nwmac nwmac deleted the endpoint-list-user-deets branch August 31, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoints tab: Add user name and user type (admin/user) to table
4 participants