Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update side nav logo with light version of new logo #2921

Merged
merged 4 commits into from
Dec 13, 2018

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Aug 28, 2018

  • Requires 'light version' review
  • Requires downstream update

Depends on #2919

@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #2921 into v2-master will decrease coverage by 0.07%.
The diff coverage is 65.04%.

@@              Coverage Diff              @@
##           v2-master    #2921      +/-   ##
=============================================
- Coverage      71.08%   71.01%   -0.08%     
=============================================
  Files            633      639       +6     
  Lines          27761    28021     +260     
  Branches        6319     6387      +68     
=============================================
+ Hits           19735    19898     +163     
- Misses          8026     8123      +97

@nwmac nwmac changed the title WIP: Update side nav logo with light version of new logo Update side nav logo with light version of new logo Dec 12, 2018
Copy link
Contributor Author

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just requires green tick with newer code

@richard-cox richard-cox merged commit 663b074 into v2-master Dec 13, 2018
@richard-cox richard-cox deleted the logo-update-2 branch December 13, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants