Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wiredep to Gulp for injecting Bower components #30

Merged
merged 2 commits into from
Jan 19, 2016
Merged

Conversation

ongk
Copy link
Contributor

@ongk ongk commented Jan 19, 2016

Use wiredep to inject Bower components (dependencies). This doesn't cover the private repos (helion-ui-framework and helion-ui-theme) currently.

bower: {
directory: '../src/lib/',
ignorePath: '../src/',
json: require('./bower.json')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we rename json to bowerJson then in gulpfile we can just

.pipe(wiredep(config.bower))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sean-sq-chen
Copy link
Contributor

Great change! one comment for a nit.

sean-sq-chen added a commit that referenced this pull request Jan 19, 2016
Add wiredep to Gulp for injecting Bower components
@sean-sq-chen sean-sq-chen merged commit 53c3348 into master Jan 19, 2016
@ongk ongk deleted the add-wiredep branch January 20, 2016 20:00
irfanhabib pushed a commit that referenced this pull request Jun 1, 2017
irfanhabib pushed a commit that referenced this pull request Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants