CF API v2 Usage #3053
Merged
CF API v2 Usage #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Sep 24, 2018
richard-cox
commented
- fixes Create basic analysis of v2 cf api feature usage #2937
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
nwmac
reviewed
Sep 24, 2018
Codecov Report
@@ Coverage Diff @@
## v2-master #3053 +/- ##
=============================================
- Coverage 71.02% 71.01% -0.02%
=============================================
Files 607 607
Lines 26250 26258 +8
Branches 5940 5940
=============================================
+ Hits 18645 18648 +3
- Misses 7605 7610 +5 |
nwmac
suggested changes
Sep 24, 2018
docs/cf-api-v2-usage.md
Outdated
|
|
||
| ### Current v2 Issues | ||
|
|
||
| - Most list fetch all entities up front to provide a reasonable level of sorting and filtering |
There was a problem hiding this comment.
I think this should be "Most lists" - i.e. plural
docs/cf-api-v2-usage.md
Outdated
| - Filtering sometimes contains org, space and name, but not all | ||
| - Calculated numerical summary stats (number of applications in an organisation, cumulative total of memory from running apps in an | ||
| organisation, number of users etc) requires fetching all entities of a certain type. This can be quite a costly set of requests. | ||
| - Determining an informative application state requires an additional request to the `application/<guid>/stats` endpoint. |
There was a problem hiding this comment.
For each of these, I suggest we make a suggestion for what would help.
e.g. with this one-
It would massively improve Stratos performance if the APIs to list applications and retrieve a specific application could return the app stats for the application(s). If this is not possibly, an app stats call that can return stats for all running applications would help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.