Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: Phase 1 #3186

Closed
wants to merge 1,327 commits into from
Closed

Extensions: Phase 1 #3186

wants to merge 1,327 commits into from

Conversation

KlapTrap
Copy link
Contributor

@KlapTrap KlapTrap commented Nov 8, 2018

See #3176 for context

@cfdreddbot
Copy link

Hey KlapTrap!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@KlapTrap KlapTrap mentioned this pull request Nov 8, 2018
richard-cox and others added 27 commits January 18, 2019 14:03
…orrect time. (#3363)

* Fix list component refresh vs. loading logic

* Ensure we don't needlessly modify the pagination client filter object

* Ensure the refresh button animates on first click on non-local lists

* Tidy up

* Merge fixes
* Change log for 2.3.0

* Fixed `JSON Schemas ` line

* Fixed JSON scheme line link
…rvice-e2e

Allow e2e createService helper 3 attempts at creating a service
Only prevent copy & paste in confirm dialog for production
- Enables other entities to easily use observables for determinng maxed world state
- Add additional obs to PaginationObservables
- Tidy up endpoint service app observables
- Removed unused card-cf-usage component
- Ensure user table space column displays space prefix & 'can't find roles'
  message correctly based on actual level rather than number of spaces
- Ensure org count request is ignored when checking for missing roles
- Fix e2e tests
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #3186 into extensions-phases will decrease coverage by 21.97%.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           extensions-phases    #3186       +/-   ##
======================================================
- Coverage              71.13%   49.15%   -21.98%     
======================================================
  Files                    632      694       +62     
  Lines                  27683    30746     +3063     
  Branches                6297     6995      +698     
======================================================
- Hits                   19691    15114     -4577     
- Misses                  7992    15632     +7640

@KlapTrap
Copy link
Contributor Author

This has already been merged. Closing!

@KlapTrap KlapTrap closed this Jun 10, 2019
@nwmac nwmac deleted the monorepo branch April 10, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants