Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when navigating away from the first deploy app step #3277

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

KlapTrap
Copy link
Contributor

No description provided.

@cfdreddbot
Copy link

✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA.

@KlapTrap KlapTrap requested a review from richard-cox December 11, 2018 18:10
@KlapTrap KlapTrap added the bug label Dec 11, 2018
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #3277 into v2-master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##           v2-master    #3277      +/-   ##
=============================================
- Coverage      71.08%   71.07%   -0.01%     
=============================================
  Files            638      638              
  Lines          27978    27979       +1     
  Branches        6377     6378       +1     
=============================================
- Hits           19888    19886       -2     
- Misses          8090     8093       +3

@nwmac
Copy link
Contributor

nwmac commented Dec 12, 2018

We should add an e2e test for this.

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 904a9e5 into v2-master Dec 12, 2018
@nwmac nwmac deleted the fix-deploy-app-stepper branch December 12, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants