Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale Users in CF Summary section #3371

Merged
merged 12 commits into from
Feb 18, 2019
Merged

Scale Users in CF Summary section #3371

merged 12 commits into from
Feb 18, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Jan 23, 2019

  • Only fetch users count on cf/org/space summary pages instead of all users
    • Use the following to fetch the counts
    • Level Admin Non-Admin
      CF /users Don't show stat
      Org /org/users /org/users
      Space /space/users /space/users
  • Don't show users table when there are too many users
    • Previously we'd try to fetch alllll users (via /users for admin or multiple /org/users requests)
    • Now we make a single request per level that uses flattenPaginationMax to limit the amount of response
    • For admin, mitigate this by attempting to use org or space lists, see below table
    • Level Admin Non-Admin
      CF /users or nothing if maxed Don't show users tab
      Org /users or /org/users if maxed /org/users
      Space /users or /space/users if maxed /space/users
  • Only show Retrieving Details message on cf/org/space pages when fetching apps, otherwise load data asynchronously.
  • Hide cf/org/space user table filter roles drop down when we fetch from /org or /space (lists only return users with roles)
  • Fix org level users table space column
    • Custom message and space role prefixes should show when at org level only
    • Previously this was determined by the spaces collection passed in only containing a single space
    • This was incorrectly true when an org had only one space
  • Depends on Improve handling of maxed state and observables #3370

- Enables other entities to easily use observables for determinng maxed world state
- Add additional obs to PaginationObservables
- Tidy up endpoint service app observables
- Removed unused card-cf-usage component
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #3371 into v2-master will decrease coverage by 0.03%.
The diff coverage is 61.97%.

@@              Coverage Diff              @@
##           v2-master    #3371      +/-   ##
=============================================
- Coverage       70.3%   70.26%   -0.04%     
=============================================
  Files            686      686              
  Lines          30351    30270      -81     
  Branches        6895     6894       -1     
=============================================
- Hits           21337    21268      -69     
+ Misses          9014     9002      -12

- Ensure user table space column displays space prefix & 'can't find roles'
  message correctly based on actual level rather than number of spaces
- Ensure org count request is ignored when checking for missing roles
- Fix e2e tests
@richard-cox richard-cox changed the base branch from v2-master to scale-users-2 January 24, 2019 14:40
@richard-cox richard-cox changed the base branch from scale-users-2 to v2-master January 24, 2019 14:58
- Admins at org/space level with maxed users cannot see users without roles
- Add a warning so they don't search for them
@KlapTrap KlapTrap self-requested a review January 30, 2019 17:00
@KlapTrap KlapTrap added conflicts Merge conflicts on PR and removed ready for review labels Jan 31, 2019
@richard-cox richard-cox changed the base branch from v2-master to add-metrics January 31, 2019 10:03
@richard-cox richard-cox changed the base branch from add-metrics to v2-master January 31, 2019 10:03
Nathan Jones added 2 commits February 15, 2019 13:31
* v2-master: (188 commits)
  Weekly update
  Automated test script improvements and fixes (#3402)
  Fixed date --> data typo
  Also show forked repos when suggesting github repos in deploy app
  Changes following review - Removed commented out code - Ensure we handle entities with loooooong names - Wrap recent section on thin browsers - Remove favourite actions if endpoint is disconnected - Replaced `PaginationRemoveIdAction` with existing `ClearPaginationOfEntity`
  Fix issue where autocomplete stops working
  Front-end unit test fixes for switch to http client
  Address PR Feedback
  Docs updates
  E2E: Updated endpoint table data getter
  Fixes for echo v3 upgrade
  Stop paginationResetPagination from added invalid fields
  Fix endpoint registration SSL error test
  Make sure we clear junk cookie to avoid issues
  Fix lint issue
  Fix for logging session secret detection
  Ensure we have same error output as V2
  Add logging for session store secret
  Fixed typos. Simplified
  Backend: Update to latest version of Echo Web Server (#3216)
  ...
@KlapTrap
Copy link
Contributor

LGTM - mergable when the gates have passed.

@KlapTrap KlapTrap merged commit 6ca10b0 into v2-master Feb 18, 2019
@nwmac nwmac deleted the scale-users-4 branch April 10, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants