Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show header in none dashboard pages #3597

Merged
merged 6 commits into from
Jun 10, 2019

Conversation

richard-cox
Copy link
Contributor

@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #3597 into v2-master will decrease coverage by <.01%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##           v2-master   #3597      +/-   ##
============================================
- Coverage       51.6%   51.6%   -0.01%     
============================================
  Files            723     724       +1     
  Lines          20406   20410       +4     
  Branches        3650    3651       +1     
============================================
+ Hits           10530   10532       +2     
- Misses          9876    9878       +2

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one comment

@richard-cox richard-cox added the needs attention This PR needs attention label Jun 5, 2019
@richard-cox richard-cox removed the needs attention This PR needs attention label Jun 6, 2019
@KlapTrap KlapTrap self-assigned this Jun 10, 2019
@KlapTrap KlapTrap merged commit 9f010bb into v2-master Jun 10, 2019
@nwmac nwmac deleted the show-header-in-none-dashboard-pages branch April 10, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup screens are missing header Unable to log out on 'no endpoints contact admin' page
4 participants