Entity Catalogue: Merge master, add general todo's following review #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line Concourse Release Pipeline: Fix incorrect Helm Chart URL
Fix Helm Chart Automated Test
When multiple CF were connected the user could end up with multiple services with the same name without being able to identify the source of that. Now when multiple CF endpoints are connected a CF endpoint is shown on each service card so the user can identify where it comes from. Signed-off-by: Vítor Avelino <[email protected]>
…mpose-support Remove docker compose support
marketplace: cf endpoint on card when multiple cf connected
…er-image-push Docs: CF Push Docker Image: Add missing app name
When user were navigating to apps through cf/spaces mapped routes, the breadcrumbs was losing context from the previous path. Now it preserves the previous path context. Signed-off-by: Vítor Avelino <[email protected]>
Always build with go modules
Previously the org/space quotas weren't able to be selected during the creation and edition of them. The user can now select which quota definition they want. Signed-off-by: Vítor Avelino <[email protected]>
A few enhancements were done like not showing the quota field if there's no space quota and preselecting default/first org quota. Signed-off-by: Vítor Avelino <[email protected]>
When navigating directly to create/update space an exception was being thrown when the user was redirected to summary page. Signed-off-by: Vítor Avelino <[email protected]>
Combined create and edit test cases into one file and removed previous org/space manage tests. Signed-off-by: Vítor Avelino <[email protected]>
Fix bosh prometheus metrics
Added "remove from x" item from user's action menu
Bumps [gulp](https://github.com/gulpjs/gulp) from 4.0.0 to 4.0.2. - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v4.0.0...v4.0.2)
* Add NgClass directive to reduce endpoint card opacity when disconnected and checking status. Card opacity restored on hover. (#3554). Update endpoint card no-link SCSS class definition to BEM syntax. Signed-off-by: Kate E. Reinecke <[email protected]> * Fix fade in chrome and add small transition
- tests expected new `remove` user to be a member of `e2e` and `test-e2e` orgs - tests removed these roles - subsequent tests then failed - need to switch to manually creating cf user (and uaa user) to avoid this and concurrency issues
* Add imagelist generation * Ensure patched files are removed. Add to concourse pipeline
* Get default stack from the Stacks API * Fix for stacks * Fix typos and remove unreachable return statement
* Allow appVersion in helm chart to be set to a product version * Update create-chart-helper.sh
#3651) * Disable top level remove user tests to unblock pr's - tests expected new `remove` user to be a member of `e2e` and `test-e2e` orgs - tests removed these roles - subsequent tests then failed - need to switch to manually creating cf user (and uaa user) to avoid this and concurrency issues * Add e2e uaa helpers, use to create/delete user for remove roles tests * Move uaa config into cf config * Improve search for the `e2e` user in user tables - there are now other users containing 'e2e' in there name - ensure we find the correct on after searching for `e2e` * Changes following review
* Separate the auth and uaa endpoints * Add auth_endpoint db migration * Fix cloudfoundry hosting token endpoint * Use UAA_ENDPOINT value as default AUTH_ENDPOINT, if AUTH_ENDPOINT is not explicitly configured.
* Invite user e2e tests - Configure invite client - invite to org - invite to space * Add environment for invite tests - install mailcatcher in travis container - configure travis backend to use mailcatcher - add stratos-invite uaa client setup to cf init script * Fix e2e tests following additional `e2e` user - before we were expecting one user when searching a users table for `e2e` - the new test user `e2e-remove-user` is now also returned - we really only expect the first entry to be the one we want to test with so just check that * Fix failing e2e tests given invite user updates * Add scf details to init-cf-for-e2e * Disable top level remove user tests to unblock pr's - tests expected new `remove` user to be a member of `e2e` and `test-e2e` orgs - tests removed these roles - subsequent tests then failed - need to switch to manually creating cf user (and uaa user) to avoid this and concurrency issues * Add e2e uaa helpers, use to create/delete user for remove roles tests * Move uaa config into cf config * Ensure invited users are deleted in uaa as well as cf * Improve search for the `e2e` user in user tables - there are now other users containing 'e2e' in there name - ensure we find the correct on after searching for `e2e` * Split long running tests into two, second contains all user stuff * Changes following review * Allow more time for tests to complete * Allow more attempts when creating a service instance
also includes import fixes
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
For example from EntityCatalogueHelpers.buildEntityKey(organizationSchemaKey, CF_ENDPOINT_TYPE) to getCFEntityKey(organizationSchemaKey) Also fixed org-space-post-processor
…ity-catalogue-store-merge-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge of v2-master into entity-catalogue-store
worth reviewing later commits with titles