Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExpressionChangedAfterItHasBeenCheckedError exception on home page #3667

Merged
merged 3 commits into from
Jul 15, 2019

Conversation

KlapTrap
Copy link
Contributor

This exception was only thrown when running the application in development mode. Blocked on #3666.

@cfdreddbot
Copy link

✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #3667 into v2-master will decrease coverage by <.01%.
The diff coverage is 62.5%.

@@              Coverage Diff              @@
##           v2-master    #3667      +/-   ##
=============================================
- Coverage      51.42%   51.42%   -0.01%     
=============================================
  Files            725      725              
  Lines          20567    20571       +4     
  Branches        3682     3682              
=============================================
+ Hits           10577    10579       +2     
- Misses          9990     9992       +2

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - discussed with Richard Cox

@nwmac nwmac merged commit 77b9646 into v2-master Jul 15, 2019
@nwmac nwmac deleted the fix-user-favorites-change branch July 15, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants