-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Autoscaler e2e tests #3681
Add Autoscaler e2e tests #3681
Conversation
✅ Hey zyjiaobj! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3681 +/- ##
=============================================
- Coverage 52.22% 52.21% -0.01%
=============================================
Files 785 785
Lines 23010 23015 +5
Branches 4124 4125 +1
=============================================
+ Hits 12017 12018 +1
- Misses 10993 10997 +4 |
0e646e7
to
12271d7
Compare
d2506ed
to
d283c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've moved common deploy code into a helper function and tested the non-autoscaler part. In the future we might drop this part and use the existing go-env app for autoscaler tests (the deploy step process can be brittle)
- There's a number of
e2e.sleep
, we've tried to avoid these by usingwait
functions which should be available on most pages and components - I still need to come back and test autoscaler features (after polling change) and e2e tests
8b3bea4
to
1d0f8ba
Compare
@zyjiaobj I've resolved merge conflicts and updated the PR with a few tweaks.
|
4901445
to
069e9b1
Compare
c4a7556
to
3885413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally against an SCF with autoscaler enabled in eng cloud and everything passes fine. Once we've updated our travis SCF instance with autoscaler I'll bump this through the travis gates and get it merged.
3885413
to
db7b919
Compare
db7b919
to
70056b9
Compare
27b110b
to
023ddcc
Compare
023ddcc
to
1472825
Compare
- don't reload page so often - if wait for card status fails, print card status
1472825
to
7764d27
Compare
- before.. the fetch policy request was used to determine if autoscaler was generally available, and thus had to differentiate no autoscaler and no policy - this causes issues with a new structure of response - now.. we don't need this extra code, the check if autoscaler is enabled happens higher up per cf and not per app
This reverts commit f26d9db.
This reverts commit 245facc.
This reverts commit b4753c1.
Updated with some improvements from another PR, now blocked on #4035 |
- create policy test sets a start time very close to current time (so it kicks off an autoscaling event) - when edit policy test tries to sumbit same rule the start time can appear in the past, causing the edit requet to fail - now we update the start time before editing. also then allow more time for scaling event to occurr
- Bring longer running `beforeAll`s into `it`s - Use common code when available - Remove some requirements to page load in `beforeEach`s - Combine some tests - Handle situation where quota no.s exceed page size - Search for quotas in tables - Remove some checks for pages to contain text (checks done in other functions)
- minor tidy ups
End2end test for autoscaler tab:
Test log: