Update protractor to fix travis e2e tests #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Aug 2, 2019
richard-cox
commented
- Travis uses chrome stable (now v76)
- Protractor uses webdriver npm package to download chromedriver
- Chromedriver only supported chrome v71-75
- Fix is to update protractor, which updates webdriver, which fetches updated chromedriver
- Travis uses chrome stable (now v76) - Protractor uses webdriver npm package to download chromedriver - Chromedriver only supported chrome v71-75 - Fix is to update protractor, which updates webdriver, which fetches updated chromedriver
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3747 +/- ##
=============================================
- Coverage 51.87% 51.87% -0.01%
=============================================
Files 765 765
Lines 22425 22425
Branches 4029 4029
=============================================
- Hits 11634 11633 -1
- Misses 10791 10792 +1 |
- don't reload page so often - if wait for card status fails, print card status
nwmac
suggested changes
Aug 12, 2019
richard-cox
added
ready for review
and removed
in progress
needs attention
KlapTrap
pushed a commit
that referenced
this pull request
Aug 16, 2019
* v2-master: Fix e2e test Fix cf init script given changes in broker service (#3746) Update protractor to fix travis e2e tests (#3747) Same Tweaks at space level - Show edit quota on space level quota details page - Ensure we return from edit stepper from org's space quota list, org level quota page and space level quota page - Apply permissions to edit quota Tweaks - Show edit quota on org level quota details page - Ensure we return from edit stepper from cf quota list, cf level quota page and org level quota page - Apply permissions to edit quota - Change org --> space in space level quota page - Fix validation for sub 0 values Small tweaks created unlimited-input comp / refactored quota forms org/space quotas: listing and management
KlapTrap
pushed a commit
that referenced
this pull request
Aug 20, 2019
* v3-master: (26 commits) Added fixme Fix e2e test Fix cf init script given changes in broker service (#3746) Update protractor to fix travis e2e tests (#3747) Moved more cf components from core to cf package Two tweaks - Move entityCatalogue clear into testEntityCatalogue, optionally return test if in test env - Move EffectsFeatureTestModule & TEST_CATALOGUE_ENTITIES into own test file Moved some cf components from core to cf package Removed some comments Fix cf-autoscaler unit tests Entity validation fixes Same Tweaks at space level - Show edit quota on space level quota details page - Ensure we return from edit stepper from org's space quota list, org level quota page and space level quota page - Apply permissions to edit quota Tweaks - Show edit quota on org level quota details page - Ensure we return from edit stepper from cf quota list, cf level quota page and org level quota page - Apply permissions to edit quota - Change org --> space in space level quota page - Fix validation for sub 0 values Small tweaks WIP Fix entity relations from parents test Build Fix imports after merge WIP Core - fix compile & current user permissions First pass autoscaler unit tests ...
KlapTrap
pushed a commit
that referenced
this pull request
Aug 20, 2019
* v3-master: Fix e2e test Fix cf init script given changes in broker service (#3746) Update protractor to fix travis e2e tests (#3747) Same Tweaks at space level - Show edit quota on space level quota details page - Ensure we return from edit stepper from org's space quota list, org level quota page and space level quota page - Apply permissions to edit quota Tweaks - Show edit quota on org level quota details page - Ensure we return from edit stepper from cf quota list, cf level quota page and org level quota page - Apply permissions to edit quota - Change org --> space in space level quota page - Fix validation for sub 0 values Small tweaks created unlimited-input comp / refactored quota forms org/space quotas: listing and management
KlapTrap
pushed a commit
that referenced
this pull request
Aug 21, 2019
* fix-route-create: (26 commits) Fix domain dropdown on route creation Added fav reducers back Added fixme Fix e2e test Fix cf init script given changes in broker service (#3746) Update protractor to fix travis e2e tests (#3747) Two tweaks - Move entityCatalogue clear into testEntityCatalogue, optionally return test if in test env - Move EffectsFeatureTestModule & TEST_CATALOGUE_ENTITIES into own test file Removed some comments Fix cf-autoscaler unit tests Entity validation fixes Same Tweaks at space level - Show edit quota on space level quota details page - Ensure we return from edit stepper from org's space quota list, org level quota page and space level quota page - Apply permissions to edit quota Tweaks - Show edit quota on org level quota details page - Ensure we return from edit stepper from cf quota list, cf level quota page and org level quota page - Apply permissions to edit quota - Change org --> space in space level quota page - Fix validation for sub 0 values Small tweaks WIP Fix entity relations from parents test Build Fix imports after merge WIP Core - fix compile & current user permissions First pass autoscaler unit tests ...
KlapTrap
pushed a commit
that referenced
this pull request
Aug 21, 2019
* entity-pipeline: (30 commits) Tidy up get request action method. Small fixes Fixed user apce roles data source Merge changes Fix a few low hanging fruit, added some TODOs for me Added backward compatility to old action types Added fixme Fix e2e test Fix cf init script given changes in broker service (#3746) Update protractor to fix travis e2e tests (#3747) Two tweaks - Move entityCatalogue clear into testEntityCatalogue, optionally return test if in test env - Move EffectsFeatureTestModule & TEST_CATALOGUE_ENTITIES into own test file Removed some comments Fix cf-autoscaler unit tests Entity validation fixes Same Tweaks at space level - Show edit quota on space level quota details page - Ensure we return from edit stepper from org's space quota list, org level quota page and space level quota page - Apply permissions to edit quota Tweaks - Show edit quota on org level quota details page - Ensure we return from edit stepper from cf quota list, cf level quota page and org level quota page - Apply permissions to edit quota - Change org --> space in space level quota page - Fix validation for sub 0 values Small tweaks WIP Fix entity relations from parents test Build ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.