Wire in endpoint errors to notification process #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Nov 6, 2019
richard-cox
commented
- Add a notification if there are errors connected to an endpoint
- Show the red warning bar if there are unread endpoint errors
- On close of warning bar mark error notification/s as read
- blocked on Add endpoint error page #3991 and Allow notifications to be marked as 'read' #4011
- read notifications will not be shown in the alarm bell count
…le triggered events for same config
Codecov Report
@@ Coverage Diff @@
## master #4012 +/- ##
==========================================
- Coverage 61.12% 61.06% -0.06%
==========================================
Files 860 861 +1
Lines 29359 29451 +92
Branches 4294 4313 +19
==========================================
+ Hits 17945 17985 +40
- Misses 11414 11466 +52 |
added 6 commits
November 11, 2019 17:24
* master: Update events page slightly Fix unit tests Fix exception on endpoint errors Linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.