Bump CF CLI to 6.49.0 #4182
Merged
Bump CF CLI to 6.49.0 #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
Looks good. Tested all deployment types and overrides. Tested using manifest with buildpacks (from RC - https://github.com/mauricebrinkmann/aiproject) and worked fine. Three minor comments, but think we can merge without them done.
| this.msgSub = this.messages.subscribe(); | ||
|
|
||
| // Buffer messges until each newline character | ||
| let b = ''; |
There was a problem hiding this comment.
I think you could have achieved something similar with
share(),
bufferWhen(m => m.endsWith('\n'))),
map(parts => parts.join(''))
| log "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| type v2Info struct { |
There was a problem hiding this comment.
There's a similar V2Info but in the cloud src/jetstream/repository/interfaces/structs.go Could they us the same version?
| } | ||
|
|
||
| // Get the Cloud Foundry Info | ||
| func (c *CFPushApp) setEndpointInfo(config *configv3.Config) error { |
There was a problem hiding this comment.
Could this be replaced with something like...
cfEndpointSpec, _ := p.GetEndpointTypeSpec("cf")
cnsiInfo, v2Info, err := cfEndpointSpec.Info(theCNSIrecord.APIEndpoint.String(), true)
richard-cox
approved these changes
Apr 6, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4181
This PR updates the CF CLI to 6.49.0.