Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we filter out maxed results for local lists #4241

Merged
merged 1 commit into from
May 6, 2020

Conversation

richard-cox
Copy link
Contributor

  • fixes Data Inaccuracies in PCF #4237
  • When apps collection is fetched and exceeds maxed allowed count certain pagination monitor observables were still firing with the partial collection of apps
  • This led to components who expect an apps list to show as if we had the full apps list (like count and memory), specifically space cards & summary
  • This was caused by a correction to the pagination monitor to use 'local' monitor observables instead of the incorrect non-local ones
  • The new correct observable used did not have a filter for maxed results, so emitted the bad data

Steps to reproduce

  • Create a new space
  • Create a running app in that space
  • View the space summary page and ensure the app count and memory used stats are correct and shown
  • Create another 600 apps in the same space (this number can be reduced by setting a lower stratos env var UI_LIST_MAX_SIZE or helm console.ui.listMaxSize though not lower than 100)
  • View the space summary, no memory stat should show

- When apps collection is fetched and exceeds maxed allowed certain monitor observables were still firing with the partial collection of apps
- This led to app based stats (like count and memory) to be shown on the space cards & summary
- This was caused by a correction to the pagination monitor to use 'local' monitor observables instead of non-local
- The now correct observable to use did not have a filter for maxed results, so emited the bad data
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 28, 2020

CLA Check
The committers are authorized under a signed CLA.

@richard-cox richard-cox mentioned this pull request Apr 28, 2020
9 tasks
@richard-cox richard-cox merged commit c90b07e into master May 6, 2020
@richard-cox richard-cox deleted the fix-space-app-stats branch May 6, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Inaccuracies in PCF
1 participant