Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix last two cf role permission bugs #4365

Merged
merged 14 commits into from
Jun 18, 2020
Merged

Fix last two cf role permission bugs #4365

merged 14 commits into from
Jun 18, 2020

Conversation

richard-cox
Copy link
Contributor

Routes List: Filter by org breaks when user is an org auditor

Org Managers: Disable org role checkboxes in roles stepper if not admin/org manager

Also renamed one of the three cf helper files that we have

Blocked on #4362

@richard-cox richard-cox self-assigned this Jun 11, 2020
@nwmac nwmac removed the blocked-pr label Jun 17, 2020
nwmac
nwmac approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox added needs attention This PR needs attention and removed needs attention This PR needs attention labels Jun 17, 2020
@richard-cox richard-cox merged commit b438b10 into master Jun 18, 2020
@richard-cox richard-cox deleted the space-dev-perms-2 branch June 18, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
2 participants
@richard-cox @nwmac