Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable API Keys if persistence is disabled #4616

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Sep 29, 2020

Fixes #4615

@codecov-commenter
Copy link

Codecov Report

Merging #4616 into master will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master    #4616   +/-   ##
=======================================
  Coverage   58.41%   58.41%           
=======================================
  Files         883      883           
  Lines       29301    29304    +3     
  Branches     4253     4254    +1     
=======================================
+ Hits        17115    17117    +2     
- Misses      12186    12187    +1     

@richard-cox richard-cox added the needs attention This PR needs attention label Oct 5, 2020
@richard-cox richard-cox merged commit 03ec621 into master Oct 5, 2020
@richard-cox richard-cox deleted the api-key-disable-persistence branch October 5, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Keys should not be shown when persistence is disabled
3 participants