Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Manage Roles button more visible, also add tab icon only buttons hoverable #4639

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Make Manage Roles button more visible, also add tab icon only buttons hoverable #4639

merged 2 commits into from
Oct 7, 2020

Conversation

richard-cox
Copy link
Contributor

@richard-cox
Make Manage Roles button more visible, also add tab icon only butto…
802656a 
…ns hoverable

- Manage Roles button now has text and is not an icon only button (has hover)
- Added a hover state to mat-icon-buttons tab buttons
@richard-cox richard-cox self-assigned this Oct 6, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #4639 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4639   +/-   ##
=======================================
  Coverage   58.41%   58.41%           
=======================================
  Files         883      883           
  Lines       29304    29304           
  Branches     4254     4254           
=======================================
  Hits        17117    17117           
  Misses      12187    12187

@nwmac
Copy link
Contributor

nwmac commented Oct 7, 2020 •
edited
Loading

The icon vertical alignment is off by 1px as well - adding this fixes it:

span.mat-button-wrapper {
    display: flex;
    justify-content: center;
}

This shows more with the hover background than before

nwmac
nwmac approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 8f9aa26 into master Oct 7, 2020
@nwmac nwmac deleted the user-icon branch October 7, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
comments-addressed ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Manage Roles By Username" icon isn't obviously the right place to add users to a space
3 participants
@richard-cox @codecov-commenter @nwmac