Move GET /tokens into api group
#4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Oct 26, 2020
richard-cox
commented
- this means it's available with an api key (the redirect is correctly returned but will not show in browser)
- fixes SSO Auth Doesn't Work for Endpoints #4716
- tested both uses of SSO - stratos log in and endpoint connect
- this means it's available via the api (the redirect is correctly returned but will not show in browser) - fixes #4716 - test both endpoint and stratos SSO log in
Codecov Report
@@ Coverage Diff @@
## 4.2.1 #4719 +/- ##
=======================================
Coverage 57.85% 57.85%
=======================================
Files 1062 1062
Lines 34453 34453
Branches 4904 4904
=======================================
Hits 19932 19932
Misses 14521 14521 |
9 tasks
richard-cox
added a commit
to SUSE/stratos
that referenced
this pull request
Oct 27, 2020
* Move GET `/tokens` into `api` group (cloudfoundry#4719) * Move GET `/tokens` into `api` group - this means it's available via the api (the redirect is correctly returned but will not show in browser) - fixes cloudfoundry#4716 - test both endpoint and stratos SSO log in * Ensure travis runs on the new branch (will be removed after release) * Update version, change log and package lock for 4.2.1 (cloudfoundry#4720) * Fixes following merge
richard-cox
added a commit
that referenced
this pull request
Nov 3, 2020
* Move GET `/tokens` into `api` group (#4719) * Move GET `/tokens` into `api` group - this means it's available via the api (the redirect is correctly returned but will not show in browser) - fixes #4716 - test both endpoint and stratos SSO log in * Ensure travis runs on the new branch (will be removed after release) * Update version, change log and package lock for 4.2.1 (#4720) * Update .travis.yml
richard-cox
added a commit
to SUSE/stratos
that referenced
this pull request
Nov 9, 2020
* Merge upstream (#533) * Move GET `/tokens` into `api` group (cloudfoundry#4719) * Move GET `/tokens` into `api` group - this means it's available via the api (the redirect is correctly returned but will not show in browser) - fixes cloudfoundry#4716 - test both endpoint and stratos SSO log in * Ensure travis runs on the new branch (will be removed after release) * Update version, change log and package lock for 4.2.1 (cloudfoundry#4720) * Fixes following merge * Update .travis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.