Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent icons from being displayed as text while font loads #4743

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Nov 3, 2020

Fixes #4668

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #4743 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4743   +/-   ##
=======================================
  Coverage   54.41%   54.41%           
=======================================
  Files        1121     1121           
  Lines       39000    39000           
  Branches     4905     4905           
=======================================
  Hits        21220    21220           
  Misses      17604    17604           
  Partials      176      176           

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit 4a34dfd into master Nov 3, 2020
@richard-cox richard-cox deleted the fix-icon-flashing branch November 3, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon font's show text before icon on slow loading instances
3 participants