Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move concat & concat message extra by ConcatItems #66

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: move concat & concat message extra by ConcatItems #66

merged 1 commit into from
Feb 13, 2025

Conversation

meguminnnnnnnnn
Copy link
Contributor

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

📊 Coverage Report:

File coverage threshold (20%) satisfied:	PASS
Package coverage threshold (30%) satisfied:	PASS
Total coverage threshold (83%) satisfied:	PASS
Total test coverage: 83.7% (3244/3878)

shentongmartin
shentongmartin reviewed Feb 12, 2025
View reviewed changes
@meguminnnnnnnnn meguminnnnnnnnn force-pushed the fix/wdz/concat branch 2 times, most recently from eab0289 to d742247 Compare February 12, 2025 13:24
hi-pender
hi-pender reviewed Feb 12, 2025
View reviewed changes
hi-pender
hi-pender reviewed Feb 12, 2025
View reviewed changes
hi-pender
hi-pender approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@hi-pender hi-pender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meguminnnnnnnnn meguminnnnnnnnn merged commit 7b64b27 into main Feb 13, 2025
10 checks passed
@meguminnnnnnnnn meguminnnnnnnnn deleted the fix/wdz/concat branch February 13, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shentongmartin shentongmartin shentongmartin left review comments

@hi-pender hi-pender hi-pender approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meguminnnnnnnnn @hi-pender @shentongmartin