Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react agent and host multi-agent can be composed directly as AnyGraph #72

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

shentongmartin
Copy link
Contributor

@shentongmartin shentongmartin commented Feb 19, 2025

What type of PR is this?

feat

(Optional) Translate the PR title into Chinese.

react agent 和 host multi-agent 支持导出为 AnyGraph,可直接进入编排。

description:

refactor agents to support graph composition

  • Allow export graph from react.Agent and host.MultiAgent
  • Maintain backward compatibility for direct usage

Copy link

github-actions bot commented Feb 19, 2025

⚠️ Breaking API Changes Detected

This pull request contains breaking API changes that may affect compatibility:

uncompatible api changes found: 
github.com/cloudwego/eino/flow/agent/multiagent/host
  Incompatible changes:
  - MultiAgent: old is comparable, new is not
  Compatible changes:
  - (*MultiAgent).ExportGraph: added
  - (*MultiAgent).HostNodeKey: added
  - ConvertCallbackHandlers: added

github.com/cloudwego/eino/flow/agent/react
  Incompatible changes:
  - Agent: old is comparable, new is not
  Compatible changes:
  - (*Agent).ExportGraph: added

Required Actions:

  1. Please review these changes carefully
  2. Update the user documentation to reflect these API changes
  3. Add a note in the changelog about these breaking changes

Copy link

github-actions bot commented Feb 19, 2025

📊 Coverage Report:

File coverage threshold (20%) satisfied:	PASS
Package coverage threshold (30%) satisfied:	PASS
Total coverage threshold (83%) satisfied:	PASS
Total test coverage: 83.6% (3269/3911)

@shentongmartin shentongmartin force-pushed the feat/export_agent branch 4 times, most recently from d82c895 to 3dbfda2 Compare February 19, 2025 05:46
@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025

CLA assistant check
All committers have signed the CLA.

@shentongmartin shentongmartin force-pushed the feat/export_agent branch 2 times, most recently from 426b006 to 261dd16 Compare February 19, 2025 05:55
@shentongmartin shentongmartin force-pushed the feat/export_agent branch 2 times, most recently from d1e46f4 to ae0d698 Compare February 19, 2025 08:39
Change-Id: I3266a9f116ae1767b9a6293f02f1716d80bff03f
@shentongmartin
Copy link
Contributor Author

⚠️ Breaking API Changes Detected

This pull request contains breaking API changes that may affect compatibility:

uncompatible api changes found: 
github.com/cloudwego/eino/flow/agent/multiagent/host
  Incompatible changes:
  - MultiAgent: old is comparable, new is not
  Compatible changes:
  - (*MultiAgent).ExportGraph: added
  - (*MultiAgent).HostNodeKey: added
  - ConvertCallbackHandlers: added

github.com/cloudwego/eino/flow/agent/react
  Incompatible changes:
  - Agent: old is comparable, new is not
  Compatible changes:
  - (*Agent).ExportGraph: added

Required Actions:

  1. Please review these changes carefully
  2. Update the user documentation to reflect these API changes
  3. Add a note in the changelog about these breaking changes

The breaking API detected is for react.Agent and host.MultiAgent to no longer be comparable. Since no one will actually compare these two structs, this will have no impact on existing users. We will proceed to merge and treat the changes in this PR as compatible.

@shentongmartin shentongmartin merged commit 4bfe584 into main Feb 19, 2025
13 checks passed
@shentongmartin shentongmartin deleted the feat/export_agent branch February 19, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants