Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move utils to internal #76

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

meguminnnnnnnnn
Copy link
Contributor

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

Copy link

github-actions bot commented Feb 21, 2025

⚠️ Breaking API Changes Detected

This pull request contains breaking API changes that may affect compatibility:

uncompatible api changes found: 
github.com/cloudwego/eino/utils/safe
  Incompatible changes:
  - NewPanicErr: removed

github.com/cloudwego/eino/utils/generic
  Incompatible changes:
  - NewInstance: removed
  - Pair: removed
  - ParseTypeName: removed
  - PtrOf: removed
  - Reverse: removed
  - TypeOf: removed

Required Actions:

  1. Please review these changes carefully
  2. Update the user documentation to reflect these API changes
  3. Add a note in the changelog about these breaking changes

@meguminnnnnnnnn meguminnnnnnnnn force-pushed the feat/wdz/move_utils_internal branch from d619d63 to 2a0cf78 Compare February 21, 2025 08:06
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 159 files.

Valid Invalid Ignored Fixed
158 1 0 0
Click to see the invalid file list
  • internal/safe/panic_test.go

@meguminnnnnnnnn meguminnnnnnnnn force-pushed the feat/wdz/move_utils_internal branch from 2a0cf78 to 7972e48 Compare February 21, 2025 08:07
Copy link

github-actions bot commented Feb 21, 2025

📊 Coverage Report:

File coverage threshold (20%) satisfied:	PASS
Package coverage threshold (30%) satisfied:	PASS
Total coverage threshold (83%) satisfied:	PASS
Total test coverage: 83.5% (3308/3960)

@meguminnnnnnnnn meguminnnnnnnnn merged commit f2f2f5e into main Feb 21, 2025
13 checks passed
@meguminnnnnnnnn meguminnnnnnnnn deleted the feat/wdz/move_utils_internal branch February 21, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants