Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scheduler config and support out-of-tree scheduler plugin #498

Merged

Conversation

silenceper
Copy link
Member

What type of PR is this?

  • support scheduler configurable
  • support add custom plugin

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #281

Special notes for your reviewer:

@silenceper silenceper requested review from a team as code owners September 29, 2022 13:00
@silenceper silenceper requested a review from dixudx September 29, 2022 13:00
@silenceper silenceper changed the title add scheduler config and support out-of-tree scheduler plugin [WIP]add scheduler config and support out-of-tree scheduler plugin Sep 29, 2022
@silenceper silenceper force-pushed the github-new-support-scheduler-config branch from 89f79e4 to 81398a3 Compare September 29, 2022 13:01
@silenceper silenceper force-pushed the github-new-support-scheduler-config branch from 81398a3 to c34dd26 Compare September 29, 2022 13:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

Merging #498 (3641ea3) into main (76b0dd0) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 3641ea3 differs from pull request most recent head 21e40d4. Consider uploading reports for the commit 21e40d4 to get more accurate results

@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
+ Coverage   13.07%   13.10%   +0.03%     
==========================================
  Files          65       65              
  Lines        7081     7079       -2     
==========================================
+ Hits          926      928       +2     
+ Misses       6077     6073       -4     
  Partials       78       78              
Impacted Files Coverage Δ
...m/clusternet/clusternet/pkg/scheduler/scheduler.go 4.04% <0.00%> (-0.31%) ⬇️
...ub.com/clusternet/clusternet/pkg/utils/deployer.go 6.28% <0.00%> (-0.05%) ⬇️
...ithub.com/clusternet/clusternet/pkg/agent/agent.go 1.68% <0.00%> (-0.03%) ⬇️
...ithub.com/clusternet/clusternet/pkg/utils/names.go 100.00% <0.00%> (ø)
...ternet/clusternet/pkg/scheduler/default_plugins.go
...hub.com/clusternet/clusternet/pkg/utils/version.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@silenceper silenceper changed the title [WIP]add scheduler config and support out-of-tree scheduler plugin add scheduler config and support out-of-tree scheduler plugin Oct 10, 2022
@dixudx dixudx added this to the v0.13.0 milestone Oct 20, 2022
@dixudx dixudx added the kind/feature New feature or request label Oct 20, 2022
@silenceper
Copy link
Member Author

/PTAL @dixudx

Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation. Good work!

Signed-off-by: silenceper <[email protected]>
@silenceper silenceper force-pushed the github-new-support-scheduler-config branch from 3641ea3 to 21e40d4 Compare November 1, 2022 08:55
@dixudx dixudx merged commit b211e1a into clusternet:main Nov 1, 2022
@silenceper silenceper deleted the github-new-support-scheduler-config branch November 1, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make scheduler plugins configurable
3 participants