Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error in StressTest #1324

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Fix type error in StressTest #1324

merged 1 commit into from
Mar 5, 2025

Conversation

zesty-fox
Copy link
Contributor

StressTest.py reported TypeError because float number can't be used in range(), due to // in Python doesn't always return a integer. Now it's fixed.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@b22e14c). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmstestsuite/StressTest.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1324   +/-   ##
=======================================
  Coverage        ?   68.00%           
=======================================
  Files           ?      332           
  Lines           ?    26530           
  Branches        ?        0           
=======================================
  Hits            ?    18042           
  Misses          ?     8488           
  Partials        ?        0           
Flag Coverage Δ
functionaltests 45.95% <ø> (?)
unittests 55.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wil93
Copy link
Member

wil93 commented Mar 5, 2025

Thank you!

It's interesting though, that probably this script was probably not used since the Python 2 -> 3 migration which happened many years ago.

Out of curiosity: did you manage to run the script correctly? Maybe it could make sense to run it periodically as a Github action in that case.

@wil93 wil93 merged commit 999fba6 into cms-dev:main Mar 5, 2025
3 checks passed
@zesty-fox
Copy link
Contributor Author

Thank you!

It's interesting though, that probably this script was probably not used since the Python 2 -> 3 migration which happened many years ago.

Out of curiosity: did you manage to run the script correctly? Maybe it could make sense to run it periodically as a Github action in that case.

Yes. It works well after solving this problem. I have run it for a stress test on my local machine, and it helps a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants