fail_ci_if_error should default to true #1348
Labels
enhancement
New feature or request
Low
Low Priority Issues (to be fixed or re-evaluated in 12 months
v6
Splitting out of discussion in #1293: right now, if a repository uses v4 of the action without a
CODECOV_TOKEN
, their build will fail to upload coverage data but still ✅ pass. The logs will look something like this (example run):The action not failing on an explicit
Error:
is surprising behavior. If an action fails to do its express purpose, you'd expect it to fail.Furthermore, many repositories automatically create dependency update PRs for GitHub actions. Even if they're not automatically merged, it's easy to miss in the three error/warning lines that one of them is new and actually matters now.
Separately from requests to re-allow tokenless uploading, could you please change
fail_ci_if_error
's default fromfalse
totrue
in a new major version, please?The text was updated successfully, but these errors were encountered: