-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide clarity on future of tokenless uploads from GitHub Actions #1293
Comments
Despite mentioning "PRs made from forks to the upstream public repos will support tokenless" in the changelog, this does not seem to be working at all. |
We have upgraded our codecov upload action to v4. However, tokenless uploads are unsupported now (see codecov/codecov-action#1293). This PR fixes the config to give the action a codecov token stored in repository secrets.
New codecov action breaks tokenless uploads for vague reason codecov/codecov-action#1293 This reverts commit ccd193c.
Codecov actions v4 requires CODECOV_TOKEN to be provided codecov/codecov-action#1293
Would be great to get some feedback on this. Are tokens now a hard requirement? We just updated from v3 to v4 and the upload is broken. |
Ah the token is now needed with `codecov/codecov-action@v4` codecov/codecov-action#1293
My projects that use codecov are now saying:
Is tokenless uploading gone for good now? It would be really helpful to get confirmation from someone at Codecov on this. |
Was dropping the tokenless upload feature just an unintended side effect, as #1068 seems to imply? Or is there a reason it's no long desirable? I accept that as a purely open-source user who doesn't pay Codecov, I have no claim on your time. But the v3 action works so smoothly, with no need to think about secret tokens, and I've left several projects using v3 while waiting to hear something about this. |
Hi all... Tokenless upload should still work for v3. And with v4, the tokens are required, except for when uploading from forks as detailed here @lpsinger - looking at the error, it looks like a rate limit issue - have you set up the codecov app on Github? |
Thanks Rohan!
It does! 😃 But at some point fairly soon the v3 action will stop working entirely, unless it's updated to run on Node 20: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
To be clear, are you confirming that there's no plan to change that? |
@takluyver little known secret, |
😆 OK, maybe I'll just pin 3.1.5 and see how long it carries on working for. |
@rohan-at-sentry, we'd still love an answer to this question from @takluyver:
Meanwhile I have held back all of my projects to v3 of the GitHub action. |
@lpsinger apologies for not addressing that, happy to do so now. We felt repo tokens would
To be clear, we were aware of the fact that secrets wouldn't be passed over to forks - which is why token-less uploading was and still is supported for uploads from forks. That said, we recognize that the change was not well communicated, and that setting a token can introduce friction. We're making some changes to how the tokenless flows work currently and once that ships, we're going to take a look to see how we can make this better. |
v4 dropped support for tokenless uploads on GitHub Actions due to #1068 ("use cli instead of node uploader"). In the PR description there is the comment:
Is there a plan to restore support for tokenless uploads in the the GitHub Action going forward? Tokenless uploads still work with v3, the Node uploader obviously still supports tokenless uploads. Will the CLI uploader gain support for them? The Codecov documentation still mentions tokenless uploads in lots of places.
The text was updated successfully, but these errors were encountered: