fix(remount): correct usrLibMultiarchDir value for 32-bit ARM #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jul 3, 2024
Correct, it will never match as a prefix, so nothing should happen. And |
johnstcn
pushed a commit
that referenced
this pull request
Jul 5, 2024
Co-authored-by: Cian Johnston <[email protected]> (cherry picked from commit 0c49e02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constant is for 64-bit systems. 32-bit ARM is not supported.
If ever it becomes supported, it should be handled with a
usrLib32MultiarchDirconstant.Using
/var/emptyfor unsupported directories like NVIDIA: https://github.com/NVIDIA/libnvidia-container/blob/v1.15.0/src/common.h#L53Follow up to #258