fix: update kaniko fork to fix BLOB_UNKNOWN errors #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
changed the title
mafredri
force-pushed
the
mafredri/fix-push-unknown-blob
branch
from
8ae006a to
4b71b24
Compare
johnstcn
reviewed
Nov 20, 2024
Comment on lines
+587
to
+595
| // To debug registry issues, enable logging: | ||
| // | ||
| // import ( | ||
| // stdlog "log" | ||
| // reglogs "github.com/google/go-containerregistry/pkg/logs" | ||
| // ) | ||
| // reglogs.Debug = stdlog.New(os.Stderr, "", 0) | ||
| // reglogs.Warn = stdlog.New(os.Stderr, "", 0) | ||
| // reglogs.Progress = stdlog.New(os.Stderr, "", 0) |
There was a problem hiding this comment.
non-blocking potential follow-up: we could conditionally enable this?
There was a problem hiding this comment.
I thought about it, but was too tired to think of how to expose it 😄. I'd also not use os.Stderr but instead wrap the logger we have.
I don't think we want to enable this with ENVBUILDER_VERBOSE=1, we'd probably want to introduce debug/trace.
There was a problem hiding this comment.
yup, but we can worry about that later!
johnstcn
approved these changes
Nov 20, 2024
johnstcn
pushed a commit
that referenced
this pull request
Nov 25, 2024
(cherry picked from commit e64f857)
johnstcn
added a commit
that referenced
this pull request
Dec 2, 2024
Co-authored-by: Mathias Fredriksson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #385
Refs coder/kaniko#35