Small changes #16
Merged
Small changes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengemann
reviewed
Apr 22, 2021
| @@ -120,7 +123,7 @@ def compute_features( | |||
| covs = _compute_covs_raw(inst, clean_events, fbands, duration) | |||
|
|
|||
| elif isinstance(inst, BaseEpochs): | |||
| epochs_clean = inst | |||
| epochs_clean = clean_func(inst) | |||
There was a problem hiding this comment.
I think the idea is that you pass clean epochs already.
There was a problem hiding this comment.
but OK with keeping something like this.
|
yes I think it's best to keep it that way because you may begin with epochs
coming from other's work and may want to add your own cleaning, or test the
impact of a particular cleaning function
Le jeu. 22 avr. 2021 à 22:54, Denis A. Engemann ***@***.***>
a écrit :
… ***@***.**** commented on this pull request.
------------------------------
In meegpowreg/power_features.py
<#16 (comment)>
:
> @@ -120,7 +123,7 @@ def compute_features(
covs = _compute_covs_raw(inst, clean_events, fbands, duration)
elif isinstance(inst, BaseEpochs):
- epochs_clean = inst
+ epochs_clean = clean_func(inst)
but OK with keeping something like this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIC2QGQF6V6KQGIMKNPJ4U3TKCEIPANCNFSM43NKYSTQ>
.
|
|
OK, I am fine with that.
… On 22 Apr 2021, at 22:48, David Sabbagh ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#16 <#16>
Commit Summary
cleaning the epochs too
more precise doc string of compute_features
File Changes
M meegpowreg/power_features.py <https://github.com/DavidSabbagh/meegpowreg/pull/16/files#diff-448b55185af85956ad4f9bb084550b8f3a2c33c563c41c601a77f73392dcf4d0> (19)
Patch Links:
https://github.com/DavidSabbagh/meegpowreg/pull/16.patch <https://github.com/DavidSabbagh/meegpowreg/pull/16.patch>
https://github.com/DavidSabbagh/meegpowreg/pull/16.diff <https://github.com/DavidSabbagh/meegpowreg/pull/16.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#16>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOR7CQDHR6ODBTEZCIWWK3TKCDSTANCNFSM43NKYSTQ>.
--
Dr. Denis-Alexander Engemann
Research Scientist at Inria-Saclay, Parietal team, Paris, France
Visiting Fellow at the Max Planck Institute for Human Cognitive and Brain Sciences, Department of Neurology, Leipzig, Germany
https://denis-engemann.de
https://twitter.com/dngman
https://github.com/dengemann
|
|
@DavidSabbagh thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.