Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes #16

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Small changes #16

merged 3 commits into from
Apr 22, 2021

Conversation

DavidSabbagh
Copy link
Collaborator

No description provided.

@@ -120,7 +123,7 @@ def compute_features(
covs = _compute_covs_raw(inst, clean_events, fbands, duration)

elif isinstance(inst, BaseEpochs):
epochs_clean = inst
epochs_clean = clean_func(inst)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that you pass clean epochs already.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but OK with keeping something like this.

@DavidSabbagh
Copy link
Collaborator Author

DavidSabbagh commented Apr 22, 2021 via email

@dengemann
Copy link
Collaborator

dengemann commented Apr 22, 2021 via email

@dengemann dengemann merged commit 6dc0094 into main Apr 22, 2021
@dengemann
Copy link
Collaborator

@DavidSabbagh thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants