Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default Riemann projection scale to auto #32

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

hubertjb
Copy link
Contributor

@hubertjb hubertjb commented Mar 8, 2022

@dengemann if I remember correctly the default scale for Riemann projection had to be changed from 1 to 'auto'.

@dengemann
Copy link
Collaborator

not sure we finished discussing this topic. there is still something to understand as this rescaling shouldn't be necessary, in principle.

@agramfort
Copy link
Collaborator

what is the scale parameter doing?

@dengemann
Copy link
Collaborator

remember it normalises covariances by trace (total power)

@dengemann
Copy link
Collaborator

Thanks a lot @agramfort you make my day. Any HTML output to share?

@dengemann dengemann merged commit bcf6c9c into coffeine-labs:main Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants