Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing frequency bands default to avoid including alpha band if user provides a value #33

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Changing frequency bands default to avoid including alpha band if user provides a value #33

merged 1 commit into from
Mar 9, 2022

Conversation

hubertjb
Copy link
Contributor

@hubertjb hubertjb commented Mar 8, 2022

This addresses #26. I left the default in, but just made sure that the alpha band would not be included if the user provides a value.

@agramfort
Copy link
Collaborator

@dengemann merge if happy

can it impact our results with @apmellot ?

@dengemann
Copy link
Collaborator

I understand that this only produces a bug if you do not pass all bands.

@dengemann dengemann merged commit 4caaf99 into coffeine-labs:main Mar 9, 2022
@dengemann
Copy link
Collaborator

thanks @hubertjb !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hubertjb @agramfort @dengemann