Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include custom metadata columns. #37

Closed
wants to merge 1 commit into from

Conversation

tmog
Copy link
Member

@tmog tmog commented Feb 25, 2015

Change data provider for brains to include all metadata except for certain plone standard metadata. Note this is an api change from including a specific set. This change only adds additional data in json output however.
Is this an acceptable change?

…nclude all metadata except for certain plone standard metadata. Note this is an api change from including a specific set. This change only adds additional data in json output however.
@tmog tmog changed the title include custom metadata columns. Change data provider for brains to incl... include custom metadata columns. Feb 25, 2015
@ramonski
Copy link
Contributor

ramonski commented Mar 2, 2015

@tmog thanks for you pull request. Unfortunately I'm quite busy at the moment, but I'll check the changes as soon as I have time and give you a proper feedback.

ramonski added a commit that referenced this pull request Sep 5, 2015
fetch keys from metadata schema fields.
Ignore mapped metadata.
Added test.

All changes adapted from #37 by @tmog

This implements #37
@ramonski
Copy link
Contributor

ramonski commented Sep 5, 2015

Implemented in a13e671

@ramonski ramonski closed this Sep 5, 2015
@ramonski ramonski deleted the include_custom_metadata_columns branch January 27, 2016 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants