2019 12 14 multithreading #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
executor with the selected number of Threads.
Futures and call their .get() methods for showing the progress bar and for calculating the gain.
to 100 px, so that the label texts fit ino the column.
"try-with-resources" statements so that files are reliably closed. Synchronized logging to log panel. Added number of threads to ini file.
error messages disappear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a pull request which adds multithreading support to JPEGOptimizer. It detects the number of logical CPUs and offers an additional dropdown in the GUI for selecting up to this number threads for parallel optimizing. Also, I ran SpotBugs for finding possible stability issues and refactored some code to make use of the Java "try-with-resources" statement for reliably closing file resources.
I increased the with of the label column from 75 to 125 pixels because labels were not fully displayed on my machine. I tested the code with Java 8, but I think Java 7 will also be able to run it.