Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 24.04 #188

Merged
merged 66 commits into from
Apr 30, 2024
Merged

Ubuntu 24.04 #188

merged 66 commits into from
Apr 30, 2024

Conversation

andiradulescu
Copy link
Collaborator

@andiradulescu andiradulescu commented Jan 15, 2024

@adeebshihadeh created a new 24.04 branch from the previous 22.04 branch. Just keep in mind that this branch is dirty. I have some things inside that won't be in the final branch. Will clear them out in the end or open a separate pull request for the final one.

Continuation of #182 and #183

@andiradulescu andiradulescu mentioned this pull request Jan 15, 2024
@andiradulescu andiradulescu marked this pull request as draft January 15, 2024 18:49
@andiradulescu andiradulescu mentioned this pull request Jan 15, 2024
@andiradulescu
Copy link
Collaborator Author

@adeebshihadeh for mapbox-gl-native to compile in 24.04 there are 3 options (in order of difficulty - last being the harder):

  • install g++-9 (used by default in 20.04)
  • install g++-11 (used by default in 22.04) but it needs this small change - andiradulescu/mapbox-gl-native@630057f
  • make it compile on g++-13 (used by default in 24.04)
    (default versions can be found here)

What's your view on this? And your view in general? I'm more interested in the view than just picking the option.

Should I use every shortcut possible to make the 24.04 system image and reach the target? Or also try and bump deps/compile on 24.04 default compiler/etc.

I suggest using the fastest approach and then submit separate PRs for bumping deps/etc.

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Jan 16, 2024

Generally, we don't want to be tied to old stuff if there's no good reason for it. I don't really care about reaching the target as fast possible. The goal is always maintainability, so progress can't be at the cost of complexity.

For that specific issue, I believe commaai/openpilot#26739 should ultimately fix this, so I'm ok with a very minimal (and local) hack to make it work. (You might want to try out that bounty, it might just be drop-in.)

@adeebshihadeh
Copy link
Contributor

A good chunk of the work is done here and we have 24.04 booting. @andiradulescu you've got an extended lock on this bounty until the real 24.04 release date (end of April) so you can work on other bounties.

@andiradulescu
Copy link
Collaborator Author

andiradulescu commented Feb 3, 2024

Just a small update here. The last commits from 2 weeks ago (chmod/chown fixes), make the spinner and spinner.update_progress show the progress correctly, but when reaching ui, it doesn't go over this assert (egl is null for some reason):

  // ensure we have a valid eglDisplay, otherwise the ui will silently fail
  void *egl = native->nativeResourceForWindow("egldisplay", w->windowHandle());
  assert(egl != nullptr);

Just to clear out, this has (yet) no connection with #205. This PR is with weston 1.9.0.

@andiradulescu andiradulescu marked this pull request as ready for review April 30, 2024 08:32
@adeebshihadeh adeebshihadeh changed the base branch from master to 24.04 April 30, 2024 17:25
@adeebshihadeh adeebshihadeh merged commit d665e03 into commaai:24.04 Apr 30, 2024
1 check passed
@andiradulescu andiradulescu mentioned this pull request Jul 4, 2024
20 tasks
@andiradulescu andiradulescu mentioned this pull request Jul 25, 2024
30 tasks
adeebshihadeh added a commit that referenced this pull request Aug 13, 2024
* Ubuntu 24.04 (#188)

* separate out qtwayland5 compilation

* ubuntu 22.04

* temp build system image

* remove bionic deps

* temp packages update

* update armhf packages

* back to libstdc++6

* replaced remove dqt5-default meta package with actual depss

* fix for build libqmi crashing with /usr/bin/env: 'python': No such file or directory

* mapbox-gl-native gcc11 fix

* openpilot_dependencies.sh change

* ubuntu-base 24.04 daily current

* apt install meson because PEP 668

* temp g++-11 for mapbox-gl-native

* bump capnproto to 1.0.2

* temp build only agnos-compiler-mapbox-gl-native

* Fixes for compiling mapbox-gl-native

* Fixes for compiling ffmpeg

* Build main system image again

* pyopencl from git since no 2023.1.5 release since inducer/pyopencl#705

* Try to fix checkinstall - no success

* apt capnproto & ffmpeg since can't figure out issue with checkinstall

* Commented removed services disable

* Ubuntu 24.04 currently has arm-none-eabi/12.2.1 but just use wildcard to go to first folder

* pyclean is missing ?!

* ubuntu-latest in tests workflow

* Updated README

* Reverted internal/package_ota.py changes

* rebuilt kernel

* poetry.lock update

* Simplified build_system pipeline

* headers for capnproto

* Fix typo

* Fix for checkinstall

* Reverted apt capnproto & ffmpeg

* Some cleaning in Dockerfile

* 24.04 libwayland-client

* libffi6:armhf deb file

* Updated qtwayland

* Revert "libffi6:armhf deb file"

This reverts commit bb9cb5d.

* libffi.so.6.0.4

* qt5-qmake qtbase5-dev qtbase5-dev-tools already in qt5-default

* Removed qtwayland old files

* checkinstall temp fix

* QStandardPaths: wrong permissions on runtime directory /var/tmp/weston, 0770 instead of 0700

* temp permissions fix makes loading build spinner show

* temp build optimization

* 24.04 new libs

* build kernel don't use tools on aarch64/arm64

* updated boot image and ko files

* cleaning

* switch to release 24.04

* wip - downgrade qt and libwayland

* polkitd-pkla package to support polkit *.pkla

* fixed issue with old qt needing libssl 1.1.1f

* remove /.dockerenv file

* more cleaning

---------

Co-authored-by: Justin Newberry <[email protected]>
Co-authored-by: Adeeb Shihadeh <[email protected]>

* Ubuntu 24.04 branch fixes (#235)

* bump version

* /lib64 is now UsrMerged

* latest pip poetry; poetry.lock update

---------

Co-authored-by: Adeeb Shihadeh <[email protected]>

* revert README

* [upload]

* disable failing nvmf-autoconnect.service

* disable failing networking.service

* [upload]

* no replacement for ondemand.service

* snapd.service is in snapd package we don't install

* nfs is using rpc-pipefs-generator now, when used

* checkinstall is still not fixed so remove TODO

* updated comment about usr merged lib64

* added checkinstall bug link

* removed not used libffi.so.6 and libwayland-client.so.0

* cleaned compile-qtwayland5.sh and removed 5.15 patch

* removed unused qt-comma 5.15 deb

* cleaned up custom debs for qt and libwayland and added a README

* fixed typo [upload]

* change version

* build-libwayland-deb.sh

* build-qt-deb.sh

* cleaned README

* [upload]

* fix libdl.so qtwayland build [upload]

* rebuild debs

* update libdl path [upload]

* added missing systemd-resolved

* ping capability

* disable some systemd services

* etc/resolv.conf link should not be needed

* Revert "etc/resolv.conf link should not be needed"

This reverts commit b627615.

* Revert "ping capability"

This reverts commit 812ca35.

* set ping capability outside of container

* disable systemd services: console-setup and sfsconfig

Co-authored-by: Robin Reckmann <[email protected]>

* disabled more systemd services

* bump version [upload]

* update version

---------

Co-authored-by: Justin Newberry <[email protected]>
Co-authored-by: Adeeb Shihadeh <[email protected]>
Co-authored-by: Robin Reckmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants