-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HKG: Car Port Hyundai Ioniq 5 PE (HDA2 & LFA2) #1676
Draft
devtekve
wants to merge
103
commits into
commaai:master
Choose a base branch
from
sunnypilot:2025-ioniq5-pe-to-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/CARS.md # opendbc/car/hyundai/interface.py
# Conflicts: # opendbc/car/hyundai/values.py # opendbc/dbc/hyundai_canfd.dbc
# Conflicts: # opendbc/car/hyundai/carcontroller.py
# Conflicts: # opendbc/dbc/hyundai_canfd.dbc
3ec6a94
to
2bd1cd6
Compare
This reverts commit a84b530.
fixes
2bd1cd6
to
eebbb8e
Compare
This commit introduces fingerprint detection, configuration, and documentation updates for the Hyundai Ioniq 5 PE with HDA II (2025+).
eebbb8e
to
d6d4f0b
Compare
Include a new test route for the Hyundai Ioniq 5 PE model, supporting LKA steering, HDA2, and LFA2 functionalities. This ensures better coverage for testing this vehicle variant.
8 tasks
Refined angle steering and max torque handling to enhance driver override detection and smooth dynamic adjustments. Introduced adaptive ramp rates and speed-based torque limits, ensuring better alignment with vehicle behavior. Updated angle and torque parameters for improved system responsiveness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds angle control functionality specifically for the Hyundai Ioniq 5 PE model. Changes were made across several files and variables to accommodate this additional feature. This control type provides enhanced handling and steering performance depending on the driving conditions, given its ability to adjust steering angle precisely.
e1107f9d04dfb1e2/00000453--d7a3614ba8
e1107f9d04dfb1e2/00000455--9b2328ec73
Note1
The logic has really been built by @sunnyhaibin for #1674 which is still WIP as well, this is just a "clean" version for ioniq 5 PE
Note2
Do not test / use this yet, there's still work and safety validations that need to happen before it can be used