-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
safety: only run rx hooks on whitelisted msgs #1903
Conversation
rivian is also bad!
Just did the structure so far, will fix the bugs in another PR first. @adeebshihadeh Did you have any thoughts about how this is done? Maybe it's cleaner if this hook returns a bool like the others, so |
@@ -296,6 +301,7 @@ static safety_config chrysler_init(uint16_t param) { | |||
const safety_hooks chrysler_hooks = { | |||
.init = chrysler_init, | |||
.rx = chrysler_rx_hook, | |||
.rx_relay_malfunction = chrysler_rx_relay_malfunction_hook, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.rx_relay_malfunction = chrysler_rx_relay_malfunction_hook, | |
.stock_ecu_hook = chrysler_stock_ecu_hook, |
?
There's actually failures in 7 safety modes, and the Hyundai ones seem the most complex to fix. We might need to clean up the safety first. Going to fix the latest one only for the release (Rivian): #1949 @jyoung8607 Toyota SEC OC doesn't define different RX checks, so it's missing some of the new addresses, can you fix? |
* don't run rx hook on non-allowed messages * better name * fix toyota (bug w/ secoc) * looks like honda is broken * rivian is also bad! (missing EPAS_SystemStatus) * misra so far rivian is also bad! * nissan is fine * tesla is also borked * mazda's good * subaru's fine * gm broke * ford's good * chrysler's good * vw is good * hyundai is broky, canfd is good * Fix Rivian * revert these * do relay malfunction check on all addresses * Found a Tesla bug * fix subaru pg * body * rm * Fix Honda * stash * fix Hyundai * fix * Hyundai: buttons are used always (for interaction) * revert tesla * body: we don't rx _torque_cmd_msg * Revert "body: we don't rx _torque_cmd_msg" This reverts commit 2f973f6. * simpler * GM EV param for correct rxchecks * no need * might read better * rm extras * fix hyundai * we weren't testing lfa (non-hda2), alt buttons, long * fix * tested * rm * not needed * clean up * that too * .
#1851 but for rx
catches a few missing rx checks: