Hyundai Safety: Safety flags in one place #1964
Open
+87
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyhaibin
force-pushed
the
hyundai-safety-flags
branch
from
d0d8f83 to
e6d18b1
Compare
sunnyhaibin
added a commit
to sunnypilot/opendbc
that referenced
this pull request
Mar 10, 2025
sunnyhaibin
added a commit
to sunnypilot/opendbc
that referenced
this pull request
Mar 10, 2025
This reverts commit c325de2.
sshane
reviewed
Mar 10, 2025
sshane
reviewed
Mar 10, 2025
Comment on lines
37
to
41
| const int HYUNDAI_PARAM_EV_GAS = 1; | ||
| const int HYUNDAI_PARAM_HYBRID_GAS = 2; | ||
| const int HYUNDAI_PARAM_CAMERA_SCC = 8; | ||
| const int HYUNDAI_PARAM_CANFD_LKA_STEERING = 16; // TODO: rename for support with CAN/CAN FD Blended platforms | ||
| const int HYUNDAI_PARAM_FCEV_GAS = 256; |
There was a problem hiding this comment.
This doesn't feel any cleaner and still has the same issue of out of order flags
There was a problem hiding this comment.
I can try using anonymous enum, similar to this:
opendbc/opendbc/safety/safety/safety_hyundai_common.h
Lines 13 to 18 in 75d4e0e
…fety-flags # Conflicts: # opendbc/safety/safety/safety_hyundai_common.h
sshane
reviewed
Mar 12, 2025
| @@ -318,16 +315,14 @@ static safety_config hyundai_init(uint16_t param) { | |||
| } | |||
|
|
|||
| static safety_config hyundai_legacy_init(uint16_t param) { | |||
| hyundai_flags(param); | |||
There was a problem hiding this comment.
this is a much more ambiguous name than hyundai_common_init
sshane
reviewed
Mar 12, 2025
| @@ -286,9 +286,6 @@ static safety_config hyundai_init(uint16_t param) { | |||
| HYUNDAI_LONG_COMMON_TX_MSGS(2) | |||
| }; | |||
|
|
|||
| hyundai_common_init(param); | |||
| hyundai_legacy = false; | |||
There was a problem hiding this comment.
keep non-common bools where they are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safety_hyundai_flags.h:hyundai_common_flagshyundai_flagshyundai_canfd_flagshyundai_legacyvariable