AlignedBuffer: avoid unnecessary data copying when already aligned #32698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
deanlee
force-pushed
the
cereal_improve_aligned_buffer
branch
from
21560cb to
b597143
Compare
deanlee
force-pushed
the
cereal_improve_aligned_buffer
branch
2 times, most recently
from
284985c to
dc1ae59
Compare
|
This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity. |
deanlee
force-pushed
the
cereal_improve_aligned_buffer
branch
from
dc1ae59 to
82d7e2f
Compare
|
This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity. |
deanlee
force-pushed
the
cereal_improve_aligned_buffer
branch
from
82d7e2f to
dcba7a3
Compare
|
This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update optimizes memory usage and execution time by avoiding unnecessary data copying when data is already aligned, which is typically the case. It improves the performance of handling Capnp messages, particularly in critical code blocks like
can_send_thread(),can_capnp_to_can_list_cp(#32009), etc.Cap'n Proto also performs the same alignment check internally. You can see an example of this in the following code snippet:
https://github.com/capnproto/capnproto/blob/f668fb59515d182ef3e6cefa7842662d4b37a8d7/c%2B%2B/src/capnp/compat/websocket-rpc.c%2B%2B#L49-L63