BUG: consistent return for value of uninitialized data #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Before integrating, would it be possible to add a comment explaining what is the value |
When a dataset cannot be initialized, log an error and return an empty string for consistency. Also do not cache value (means that a future call may succeed with correct value if data file becomes available) Fixes commontk#749
pieper
force-pushed
the
749-tag-cache-on-bad-data
branch
from
58fa2a2 to
295dbfc
Compare
|
Thanks for the review 👍 I updated the comment. The exact value 00ff,eeee is arbitrary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dataset cannot be initialized, log an error
and return an empty string for consistency.
Also do not cache value (means that a future call may
succeed with correct value if data file becomes available)
Fixes #749