This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Fix linking on windows #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
reviewed
Jul 13, 2017
| let r = gcc::windows_registry::find(target.as_str(),"msbuild.exe") | ||
| .expect("could not find msbuild") | ||
| .args(&["win\\libsass.sln", "/p:LIBSASS_STATIC_LIB=1", "/p:Configuration=Release", | ||
| "/p:WholeProgramOptimization=false", |
There was a problem hiding this comment.
is that arg necessary? Isn't it going to be slower with that?
There was a problem hiding this comment.
Unfortunately, it would not link unless I disabled Whole Program Optimization - the linker would say it was going to restart with link time code generation enabled, and then crash.
There was a problem hiding this comment.
Ah too bad, hopefully it doesn't harm performance too much
There was a problem hiding this comment.
FYI - just stumbled across this. rust-lang/rust#26003
There was a problem hiding this comment.
Thanks, tried on #15 but it seems to be nightly only :/
|
Amazing thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linking on Windows by disabling link time code generation, and adds testing target i686-pc-windows-msvc to AppVeyor.